grist-core
grist-core copied to clipboard
gristlabs
Webhook delete event type
It would be great to expand the event types the webhook functionality offers, by adding the delete event. I'd envision it containing the contents of the deleted row, similar to the create/update event types.
It may also be handy to have the event type as a field within the webhook payload, just to remove any ambiguity around what the trigger was.
Cross reference to https://community.getgrist.com/t/webhooks-curently-have-for-update-and-adding-but-we-lack-a-way-to-be-notified-for-deletion/4362/ Are there any updates on this item?
Hi, I begin to check how to implement that on Grist. I see multiple commented code about "remove" trigger event types. I want to know why is commented ? Do you have a particular reason about that ? Or it's just a TODO comments ?
Hi, I begin to check how to implement that on Grist. I see multiple commented code about "remove" trigger event types. I want to know why is commented ? Do you have a particular reason about that ? Or it's just a TODO comments ?
Those were TODO level comments by @alexmojaki (the implementer). My memory is that deletion would require some care but was very doable. Thanks for looking at it!
Hi, I begin to check how to implement that on Grist. I see multiple commented code about "remove" trigger event types. I want to know why is commented ? Do you have a particular reason about that ? Or it's just a TODO comments ? Commented here and here
Those were TODO level comments by @alexmojaki (the implementer). My memory is that deletion would require some care but was very doable. Thanks for looking at it!
You're welcome. I implement first version. I'm not sure if my "workaround" is clean. I explain on the pull request why I made this "workaround".
Thx for the reply ^^