grist-core icon indicating copy to clipboard operation
grist-core copied to clipboard

fix: Column alignment when zoom font only settings in browser

Open hexaltation opened this issue 1 year ago • 4 comments

Fix proposal for #1035

Use rem value instead of fixed pixel where needed. Removed inline style 52px for .gridview_data_row_num

hexaltation avatar Jun 12 '24 10:06 hexaltation

(apologies, I'm going to use this PR as a guinea pig to examine exactly why our machinery for deploying previews of PRs doesn't function for PRs from forks)

paulfitz avatar Jun 13 '24 17:06 paulfitz

One note I'd like to add is to be sure to test this with frozen columns.

dsagal avatar Jun 20 '24 20:06 dsagal

(apologies, I'm going to use this PR as a guinea pig to examine exactly why our machinery for deploying previews of PRs doesn't function for PRs from forks)

If it can improve this workflow it's a pleasure :)

hexaltation avatar Jun 20 '24 20:06 hexaltation

(apologies, I'm going to use this PR as a guinea pig to examine exactly why our machinery for deploying previews of PRs doesn't function for PRs from forks)

If it can improve this workflow it's a pleasure :)

Update: we know what the issue is, and making it works needs some rejiggering to the workflow that @SleepyLeslie will be looking at.

paulfitz avatar Jun 20 '24 22:06 paulfitz

@berhalak I've made the needed changes according to your suggestions. Can you re-review it ?

hexaltation avatar Jul 23 '24 10:07 hexaltation

One note I'd like to add is to be sure to test this with frozen columns.

:+1:

hexaltation avatar Jul 23 '24 10:07 hexaltation

Deployed commit 3678ab2232d61f81538b4884ebd66a6b81302e3b as https://grist-hexaltation-grist-core-1035-align-columns-when-zoom.fly.dev (until 2024-08-22T10:04:23.218Z)

github-actions[bot] avatar Jul 23 '24 10:07 github-actions[bot]

Thanks @hexaltation !

berhalak avatar Jul 23 '24 12:07 berhalak