angular-local-storage icon indicating copy to clipboard operation
angular-local-storage copied to clipboard

Contribution path

Open ealves-pt opened this issue 9 years ago • 3 comments
trafficstars

Hi everyone,

So, after grooming the existing issue I came up with the following items that might require some action in the future.

Bugs

  • [ ] localStorage not persistant in Cordova (#202)
  • [ ] Problem returning non-JSON values (#230)
  • [ ] Error when storing dates (#241)
  • [ ] Set cookie expiration to 0 (#250)

Enhancement

  • [ ] Support for selecting type of storage on the fly (#151, #192, #231, #270, #281) - Breaking Changes
  • [ ] Allow to store session cookies (#246)
  • [ ] get a non-existing key should return undefined and not null (#245) - Breaking Changes
  • [ ] set a prefix at run-time (#176) - Breaking Changes
  • [x] include source maps (#139)
  • [ ] throw exception if exceeds quota (#110)

Features

  • [ ] Specify when and how to use fallbacks (#168, #237)
  • [ ] Add support for TTL on keys (#239)
  • [ ] Sync values between different tabs (#199)
  • [ ] Add support for other storage types (#257)

Nice to have

  • [ ] Upload to a CDN (#210)

Proposals

  • [ ] Migrate source code to TypeScript and publish the API definitions on typings. This change must be backwards compatible.
  • [ ] Rewrite the entire module to tackle requested enhancements and features.

I will wait for some feedback. :smiley:

ealves-pt avatar Feb 18 '16 10:02 ealves-pt

My first thought is that many of these bugs / enhancements can be fixed without rewrite. I think we need to start there.

grevory avatar Feb 18 '16 16:02 grevory

@grevory you are right, a good number of these issues can be solved without changing many things. Meanwhile to start taking a look at the pending PR can you give me your feedback on PR #279.

ealves-pt avatar Feb 18 '16 21:02 ealves-pt

I have marked some enhancements as breaking changes because those will require some changes in the API.

ealves-pt avatar Feb 19 '16 16:02 ealves-pt