origami.el icon indicating copy to clipboard operation
origami.el copied to clipboard

Added some functionality. Better a new package or a PR?

Open alvarogonzalezsotillo opened this issue 5 years ago • 3 comments

Hello,

I have developed a new package based on origami (https://github.com/alvarogonzalezsotillo/origami-predef)

The package adds a new global mode that apply initial folding to every opened file. The lines to be folded are marked by customizable tags. For example:

   public void boringMethod(){ // *origami-this*
      foo();
      bar();
   }

I was about to publish this package in MELPA, but If you think this will be a good addition to the origami package, I would make a PR instead.

What do you think?

alvarogonzalezsotillo avatar May 26 '20 09:05 alvarogonzalezsotillo

This probably been too late. But just to inform you that I have started a new branch here. You can open issue or PR over there instead. Thanks!

jcs090218 avatar Aug 20 '20 13:08 jcs090218

I developed the origami-predefpackage (https://github.com/alvarogonzalezsotillo/origami-predef). It is very simple, and can be added to your fork without problems.

I suppose we should change the origami-predef prefix of all functions/variables (for example, to origami-auto), and add them to your fork. Just in case there is some conflicts if someone is already using the origami-predefpackage.

alvarogonzalezsotillo avatar Aug 23 '20 10:08 alvarogonzalezsotillo

Feel free to open PR if you like! This branch is currently on celpa only so I don't think there will be any conflicts!

jcs090218 avatar Aug 23 '20 11:08 jcs090218