mui-datatables icon indicating copy to clipboard operation
mui-datatables copied to clipboard

Add React 18 Support

Open kvintanaka opened this issue 3 years ago • 2 comments

Upon upgrading MUI to the latest (5.9.0) along with React 18, this issues up

Will add further details in the comment

kvintanaka avatar Jul 15 '22 00:07 kvintanaka

Agree. Needed for all new development on React 18.

kartik-v avatar Aug 06 '22 04:08 kartik-v

This is needed very much. Looking forward to it.

pintosack avatar Aug 10 '22 16:08 pintosack

Any update on this?

grantweiss avatar Oct 17 '22 22:10 grantweiss

Is greg even around anymore?

pintosack avatar Oct 26 '22 20:10 pintosack

Is this literally all that's needed?

I'm a contributor on this project and could publish an update if need be. I'd prefer any PR be in its final form before I took a look at it though. It's been a long time since I've used this project, but I could help here if this is holding people up.

@pintosack To my knowledge, no. He handed the project off a few years ago, then it got handed off to me (I was the 3rd maintainer), and then I later handed it off to someone else. These things are a lot of work and I just didn't have time to support it (plus I left the job where I was using it, so I had no incentive to work on it).

patorjk avatar Dec 02 '22 15:12 patorjk

@patorjk upgrading mui-datatables to latest stable mui and react 18 will definitely help. We use this package and are currently stuck after upgrading to MUI-5 and React 18. I can help fix this issue if no one is working on it.

Usama-Tahir avatar Dec 08 '22 04:12 Usama-Tahir

@Usama-Tahir I don't think anyone is working on it. If you make the fix I can create a new version.

patorjk avatar Dec 08 '22 14:12 patorjk

@patorjk here is the PR with the fix. https://github.com/gregnb/mui-datatables/pull/1971

Please review it whenever you get some free time and if you need some changes in the PR, please let me know.

Thanks

Usama-Tahir avatar Dec 15 '22 20:12 Usama-Tahir