react-hotkeys icon indicating copy to clipboard operation
react-hotkeys copied to clipboard

[BUG] "plus" key mapping doesn't work on mac

Open yossi-shasho opened this issue 6 years ago • 3 comments

Describe the bug "plus" key mapping doesn't work

How are you using react hotkeys components? (HotKeys, GlobalHotKeys, IgnoreKeys etc) GlobalHotKeys

{
  ZOOM_IN: "alt+plus",
}

it doens't work also without a combination, i.e. only "plus" Expected behavior Matched function should be called.

Platform (please complete the following information):

  • version 2.0.0
  • chrome latest
  • Mac OSX 14

yossi-shasho avatar Sep 04 '19 19:09 yossi-shasho

I think you should use = as the + needs a shift to be typed on mac

{
  ZOOM_IN: "alt+=",
}

ralves00123 avatar Sep 24 '19 14:09 ralves00123

Curious one, @yossi-shasho. I'd expect it to work, but there's probably an edge case in there that's stopping it. I'll have to take a look.

greena13 avatar Oct 20 '19 13:10 greena13

@ralves00123 that solves, thanks!

yossi-shasho avatar Oct 20 '19 14:10 yossi-shasho