eco-ci-energy-estimation icon indicating copy to clipboard operation
eco-ci-energy-estimation copied to clipboard

Docs: Clarify script usage, add setup files, improve README

Open KaranSinghDev opened this issue 7 months ago • 3 comments

Hi, When trying to set up this repo locally, I found pip install . doesn't work (missing setup.py/pyproject.toml), indicating the main usage is running the shell scripts directly, especially in CI. I also noticed local script execution needs specific arguments/environment variables which wasn't detailed.

To help clarify setup, I've made these improvements:

  1. Updated README.md: Clarified the script-based/CI usage model, fixed install steps (focusing on cloning + requirements.txt), added a Dependencies section, and improved local execution guidance (mentioning args/env vars needed).
  2. Added requirements.txt: Makes it easy to install the Python libraries used by the scripts (pip install -r requirements.txt).
  3. Improved .gitignore: Replaced the minimal version with a standard Python one.

My aim was to make it easier for users to understand how to set up and run this useful toolset! Amazing repo by the way.

KaranSinghDev avatar May 01 '25 15:05 KaranSinghDev

Hey @KaranSinghDev ,

thanks for using our tool!

I gotta say I do not quite understand the PR. This GitHub action does not use Python. Was it intended for a different repository?

ArneTR avatar May 01 '25 20:05 ArneTR

Hi @ArneTR Thanks for the feedback! You're right, the Action itself runs shell scripts. I am sorry if the focus on Python setup seemed misplaced. My thinking was: The shell scripts do call Python and rely on packages like psutil, codecarbon, etc. Adding requirements.txt and a standard .gitignore helps manage these Python dependencies and improves repo hygiene for local testing/understanding. Updating the README clarifies this script-based nature and makes setup clearer (install Python deps -> run scripts with args/env vars). Essentially, my aim was to improve clarity and setup for anyone interacting with the repository's components, acknowledging the primary usage is script-based within CI.

KaranSinghDev avatar May 02 '25 03:05 KaranSinghDev

Can you please point me to the line where you saw that the shell scripts call Python?

ArneTR avatar May 05 '25 09:05 ArneTR

Closing due to inactivity and unresolved questions

ArneTR avatar Jun 21 '25 08:06 ArneTR