emacs-theme-gruvbox icon indicating copy to clipboard operation
emacs-theme-gruvbox copied to clipboard

vertico-posframe has same background color as gruvbox-bg for -hard themes

Open hypirion opened this issue 8 months ago • 1 comments

Using vertico-posframe with gruvbox-light-hard and gruvbox-dark-hard results in a posframe with no visible border nor a change in background color. Seems like this is a result of the vertico-posframe clashing with with the background of the hard versions:

https://github.com/greduan/emacs-theme-gruvbox/blob/6cbf80b6cde3c2390502dc94a911ab7378495249/gruvbox.el#L939-L942

The definition of the background for the hard versions are

https://github.com/greduan/emacs-theme-gruvbox/blob/6cbf80b6cde3c2390502dc94a911ab7378495249/gruvbox-dark-hard-theme.el#L145

and

https://github.com/greduan/emacs-theme-gruvbox/blob/6cbf80b6cde3c2390502dc94a911ab7378495249/gruvbox-light-hard-theme.el#L145

which, yeah, is the same color.

As a temporary workaround I just set vertico-posframe border manually, but it'd be nice if these themes showed a border or a different background for the posframes.

hypirion avatar Mar 15 '25 18:03 hypirion

You're welcome to submit a PR with your suggested solution, but this isn't considered a bug, more a matter of taste.

PR will need to include before and after screen captures, of each Gruvbox variant.

If the PR/issue gains significant support we can consider integrating.

jasonm23 avatar Mar 16 '25 03:03 jasonm23

Closing.

jasonm23 avatar Sep 10 '25 01:09 jasonm23