daffodil icon indicating copy to clipboard operation
daffodil copied to clipboard

feat(core,category,product,search-product,reviews): use core filters

Open griest024 opened this issue 3 years ago • 10 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Product filters are used

What is the new behavior?

Filters from core are used instead

Does this PR introduce a breaking change?

[x] Yes
[ ] No
  • All filter related features have been moved to @daffodil/core and renamed in the DaffProductFilter -> DaffFilter fashion.
  • DaffCollectionMetadata#filters is a new required field

Other information

griest024 avatar Sep 15 '22 21:09 griest024

/azp run

griest024 avatar Sep 15 '22 22:09 griest024

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 15 '22 22:09 azure-pipelines[bot]

/azp run

griest024 avatar Sep 15 '22 22:09 griest024

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 15 '22 22:09 azure-pipelines[bot]

/azp run

griest024 avatar Sep 16 '22 21:09 griest024

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 16 '22 21:09 azure-pipelines[bot]

/azp run

griest024 avatar Sep 19 '22 22:09 griest024

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 19 '22 22:09 azure-pipelines[bot]

/azp run

griest024 avatar Sep 28 '22 18:09 griest024

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 28 '22 18:09 azure-pipelines[bot]

/azp run

damienwebdev avatar Dec 05 '22 18:12 damienwebdev

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 05 '22 18:12 azure-pipelines[bot]