swapi-graphql icon indicating copy to clipboard operation
swapi-graphql copied to clipboard

Flow to Typescript

Open gagoar opened this issue 5 years ago • 2 comments

Description.

I've translated everything inside src/ to typescript

TODO

  • [x] Tests passing
  • [ ] Missing scripts replacements.
  • [ ] missing prettier
  • [ ] make types more strict. (Need some guidance here) maybe @IvanGoncharov or @acao can guide me here.

This PR is stacked out of #190

gagoar avatar Nov 23 '20 07:11 gagoar

@gagoar the build failure shows the issue is with how we're set up to resolve the underlying netlify functions. there was some ways to resolve that, similarly to how binary paths are aliased using a static file that module.exports = require('./dist/file') so, somehow this is conflicting with it. it could be you are trying to compile typescript in a directory it's not configured for? i'm not sure

acao avatar Nov 24 '20 20:11 acao

@gagoar the build failure shows the issue is with how we're set up to resolve the underlying netlify functions. there was some ways to resolve that, similarly to how binary paths are aliased using a static file that module.exports = require('./dist/file') so, somehow this is conflicting with it. it could be you are trying to compile typescript in a directory it's not configured for? i'm not sure

yea I didn't look deeply into it, till my doubs about the types and how strict I'm doing things was addressed. I will work on this soon!

thanks for looking into it.

gagoar avatar Nov 24 '20 20:11 gagoar