graphql.github.io icon indicating copy to clipboard operation
graphql.github.io copied to clipboard

Published 20 hours ago • verified publisher icon graphql

Menu overflowing on mobile viewports

Open mikeesto opened this issue 5 years ago • 5 comments

Screen Shot 2020-11-07 at 12 10 46 pm

It might be worth looking at using a hamburger menu (or similar) for mobile.

mikeesto avatar Nov 07 '20 02:11 mikeesto

Is this issue open? I would like to work on it

rt1301 avatar Nov 13 '20 07:11 rt1301

Hi @rt1301 . Carolyn has made some progress on this: https://github.com/graphql/graphql.github.io/pull/957 . There still might be an opportunity to look at implementing a burger menu though!

mikeesto avatar Nov 13 '20 22:11 mikeesto

Ah sweet @mikeesto, I didn't even realize there was an issue open for this! It was bugging me while I was working on a different part of the site 😆 I merged my fix but yeah if you'd be interested in implementing a burger menu @rt1301 (or especially finding a way to keep the search bar visible at various viewpoints), that'd be amazing 🤩

carolstran avatar Nov 16 '20 14:11 carolstran

@carolstran Ok I'll work on these features. Thanks!

rt1301 avatar Nov 16 '20 14:11 rt1301

@carolstran I have made the PR with the required changes, please have a look. Thanks!

rt1301 avatar Nov 20 '20 11:11 rt1301

let's track over the PR itself

Urigo avatar Apr 09 '23 18:04 Urigo