graphql-playground icon indicating copy to clipboard operation
graphql-playground copied to clipboard

shareEnabled is not available on config typings outside of react playground

Open quinnlangille opened this issue 5 years ago • 2 comments

This issue pertains to the following package(s):

  • [ ] GraphQL Playground - Electron App
  • [x] GraphQL Playground HTML
  • [x] GraphQL Playground
  • [ ] GraphQL Playground Express Middleware
  • [ ] GraphQL Playground Hapi Middleware
  • [ ] GraphQL Playground Koa Middleware
  • [ ] GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

What is the expected behavior?

shareEnabled to be available in typings

What is the actual behavior?

shareEnabled seems to only be available in the typings for the react playground package, but works in others if we ignore TS

What steps may we take to reproduce the behavior?

Try to enable share outside of react, and see the TS error. Then ignore like so:

        const apolloServer = new ApolloServer({
            introspection: true,
            playground: {
                // @ts-ignore
                shareEnabled: true
            },
            schema,

and see share button work

Please provide a gif or image of the issue for a quicker response/fix.

quinnlangille avatar Nov 03 '20 17:11 quinnlangille

Bump, this is still an issue today

Cobular avatar Apr 21 '21 18:04 Cobular

I can just make the PR for this, will do it later today — should have done it earlier lol

quinnlangille avatar Apr 21 '21 19:04 quinnlangille