graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

Fix crash in node when mixing sync/async resolvers

Open chrskrchr opened this issue 3 years ago • 1 comments
trafficstars

Fixes #3528

Ensures that if executeFields encounters a mix of promises and thrown errors, the promises will be awaited before throwing the error.

chrskrchr avatar Aug 18 '22 18:08 chrskrchr

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 880d3bd176d25d11e30ded6f3b8f2cecabbace5a
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6348048c556859000a25e5f1
Deploy Preview https://deploy-preview-3706--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 18 '22 18:08 netlify[bot]

@saihaj - could you take a look at this PR when you have a moment? A similar had been submitted and approved previously (so it might look familiar), but I don't want to mention that PR here for risk of tainting it with CLA issues like the last PR. 😬

chrskrchr avatar Sep 23 '22 23:09 chrskrchr