graphiql icon indicating copy to clipboard operation
graphiql copied to clipboard

Fix: JS grammar detects `gql` tags in comments

Open trevor-scheer opened this issue 4 months ago • 2 comments

Just a repro for now. gql tags inside of comments are detected by the grammar and should probably be ignored. Anyone motivated to fix this: please feel free to push to this branch (if you're able) or pick my repro commit to another PR and close this one out.

Had issues running yarn vitest and yarn workspace vscode-graphql-syntax test so I added vitest as a dev dependency (and matched the version the repo uses). Perhaps I'm missing the "right" way to run these tests.

Also: not obvious to me why git is detecting the entire file changes, but hiding whitespace while reviewing reveals the actual diff in the snapshot correctly.

trevor-scheer avatar Jul 30 '25 17:07 trevor-scheer

⚠️ No Changeset found

Latest commit: 4501462f3f573f3f6cc24ec914fd1364fb77f05c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 30 '25 17:07 changeset-bot[bot]

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: trevor-scheer / name: Trevor Scheer (4501462f3f573f3f6cc24ec914fd1364fb77f05c)