graphiql icon indicating copy to clipboard operation
graphiql copied to clipboard

[vscode-graphql-syntax] Add support for GraphQL embedded in Hack files

Open dunnbobcat opened this issue 9 months ago • 4 comments

Summary: This adds support for GraphQL strings within Hack files, bootstrapped from the existing PHP version. I followed the steps outlined in the README.

Test Plan:

  • yarn test -u from package root
  • yarn vsce:package and install resulting VSIX
  • Load test.hack in VS Code
  • Observe nice syntax highlighting for GraphQL

Screenshot 2025-03-04 at 10 07 57 AM

dunnbobcat avatar Mar 04 '25 18:03 dunnbobcat

🦋 Changeset detected

Latest commit: 261039b71ea5fdecdce9c3130071da94a949a8d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-graphql-syntax Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 04 '25 18:03 changeset-bot[bot]

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: dunnbobcat / name: Bobcat (db77a2c2497ffa53545c3f5bafc7956ee5915f6b, 05537711da39baeef815c7f9032e989ab328cfaa, eb3b6ae09a5324feab0d26e13de0b2cab2f0a685, 6d9f1e19d21dcc3157fb0352d65fed9fc7630c46, 261039b71ea5fdecdce9c3130071da94a949a8d7)

@acao apologies for my GitHub noobiness, but does your force push mean this will be released? If not, is there anything I need to do to get this over the line? Thanks in advance :)

dunnbobcat avatar Jul 09 '25 17:07 dunnbobcat

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 63.96%. Comparing base (0d9e51a) to head (eb3b6ae). :warning: Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3872   +/-   ##
=======================================
  Coverage   63.96%   63.96%           
=======================================
  Files          35       35           
  Lines        3086     3086           
  Branches      948      949    +1     
=======================================
  Hits         1974     1974           
  Misses       1107     1107           
  Partials        5        5           
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 10 '25 23:07 codecov[bot]