graphql-client icon indicating copy to clipboard operation
graphql-client copied to clipboard

Support for reqwest 0.12 ?

Open sbfaulkner opened this issue 1 year ago • 5 comments

The graphql_client optional dependency for reqwest-create seems locked to 0.11

https://github.com/graphql-rust/graphql-client/blob/main/graphql_client/Cargo.toml#L23

What's needed to support use with 0.12?

I currently have issues because of conflicting versions if I try to use 0.12 in a project with reqwest and graphql_client

sbfaulkner avatar Apr 03 '24 15:04 sbfaulkner

I don't think anything is blocking support. We may want multiple feature gates for different versions of reqwest.

tomhoule avatar Apr 04 '24 11:04 tomhoule

Any progress/plans on this?

sahra-karakoc avatar Jun 05 '24 07:06 sahra-karakoc

Nobody is working on it, but I could review a PR. We need different feature flags for different versions of reqwest.

tomhoule avatar Jun 07 '24 08:06 tomhoule

Ahh, I opened a PR #490 but I'll add feature flags

jpopesculian avatar Jul 10 '24 09:07 jpopesculian

PR https://github.com/graphql-rust/graphql-client/pull/494 is better, should be able to merge as is and release a patch version

Sytten avatar Oct 05 '24 17:10 Sytten

closed by #499 I think?

sbfaulkner avatar Jan 06 '25 17:01 sbfaulkner

Indeed, thanks.

tomhoule avatar Jan 07 '25 09:01 tomhoule

Would it be possible to make a release including this change?

uncenter avatar Apr 01 '25 12:04 uncenter

Yes, there'll be a release as soon as I or another maintainer can free up some time.

tomhoule avatar Apr 01 '25 13:04 tomhoule