add support for graphql-core 3 to graphql_ws.aiohttp

[hoefling]

Signed-off-by: oleg.hoefling [email protected]

This PR adds support for graphql-core>=3 to graphql.aiohttp.AiohttpSubscriptionServer. Note that this will break the rest of the BaseSubscriptionServer implementations! Unfortunately, I am not familiar with Sanic or gevent to adapt those too.

This PR violates against the PR submission rule

3 The pull request should work for Python 2.6, 2.7, 3.3, 3.4 and 3.5, and for PyPy. Check https://travis-ci.org/graphql-python/graphql_ws/pull_requests and make sure that the tests pass for all supported Python versions.

as graphql-core>=3 is compatible with Python 3.6 onwards. Also, all of the Python versions listed have reached EOL anyway (except Python 3.5 which will reach EOL in September).

[codecov-io]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8f36f53). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage          ?   35.58%           
=========================================
  Files             ?        8           
  Lines             ?      489           
  Branches          ?       54           
=========================================
  Hits              ?      174           
  Misses            ?      303           
  Partials          ?       12           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f36f53...0b2efdc. Read the comment docs.

[bueltan]

Thank for sharing , it's really appreciated.

[dopry]

@hoefling do you have any plans to update this PR?

The wider ecosystem seems to be adopting graphql-core 3 and the version constraint here is bound to start generating issues. I'm experiencing issues in the examples for https://github.com/torchbox/wagtail-grapple since we've updated to django-graphene >= 3.

[hoefling]

@dopry let me take a look at it, it's been a while now :-)

[erikwrede]

Any objections against just integrating this into GQL-Server? Websocket-Based Subscriptions have become a common pattern in GQL and an integration would reduce the amount of duplicate code and management effort.