graphql-server icon indicating copy to clipboard operation
graphql-server copied to clipboard

Support for extensions

Open ewhauser opened this issue 6 years ago • 3 comments

In graphene-tornado, we've added support for extensions similar to Apollo Server. These extensions provide the capability to do things like add Apollo Tracing or distributed tracing to requests.

This capability would be great to add to graphql-server-core (it's a blocker for graphene-tornado to migrate). Is there interest in having this functionality in this project? Specifically, I'm suggesting we add the extension points defined here.

ewhauser avatar Sep 06 '19 20:09 ewhauser

Hi @ewhauser,

Does this issue still required or it has been solved on graphene-tornado?

KingDarBoja avatar Apr 12 '20 22:04 KingDarBoja

@KingDarBoja I have built a version of this in graphene-tornado but would love to see these extension points graphql-server-core. In graphene-tornado, you'll note that we have extension points for Apollo Tracing and OpenCensus that are built on top of this functionality. I'm sure there are a lot of Python GraphQL users who could benefit from those extensions.

I'm willing to submit a PR for this if there is interest. If we could get the extensions into graphql-server-core, then I'll convert graphene-tornado over to using it.

ewhauser avatar Apr 21 '20 19:04 ewhauser

That's great, I have already migrated graphql-server-core to use graphql-core v3, which is the latest available version, being compatible with Graphql.js v15. Right now, merging flask-graphql into it too and will do the same with sanic-graphql and so on.

Feel free to push a PR :rocket:

KingDarBoja avatar Apr 22 '20 02:04 KingDarBoja