graphql-core-legacy icon indicating copy to clipboard operation
graphql-core-legacy copied to clipboard

Add description to schema parser and printer

Open phil303 opened this issue 6 years ago • 3 comments

Descriptions are now part of the graphql spec. This commit brings graphql-core inline with the spec.

There's an additional commit in here that fixes the indent function in the printer. It's not a requirement for handling descriptions.

One note, the business logic in here is heavily lifted from the JS reference implementation.

phil303 avatar Dec 09 '18 04:12 phil303

@jkimbo @syrusakbary Hey guys, what can I do to move this PR forward?

phil303 avatar Mar 31 '19 00:03 phil303

@jkimbo @syrusakbary +1

This feature would be really useful as other GraphQL libraries in other languages support descriptions.

gizmo385 avatar Apr 04 '19 18:04 gizmo385

Another vote for getting this merged (cc @jkimbo and @syrusakbary). Thanks for this, @phil303!

waxlamp avatar Jun 21 '19 15:06 waxlamp