graphene icon indicating copy to clipboard operation
graphene copied to clipboard

feat: Add support for custom global (Issue #1276)

Open tcleonard opened this issue 3 years ago • 1 comments

Solution for issue https://github.com/graphql-python/graphene/issues/1276

tcleonard avatar Jun 20 '22 13:06 tcleonard

This is an updated version of https://github.com/graphql-python/graphene/pull/1278 You can find on the old one the discussions around the feature

tcleonard avatar Jun 20 '22 13:06 tcleonard

@ulgens Do you have time for a review?

erikwrede avatar Aug 27 '22 16:08 erikwrede

Codecov Report

Merging #1428 (d1f6412) into master (b20bbdc) will increase coverage by 0.16%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   95.72%   95.88%   +0.16%     
==========================================
  Files          50       51       +1     
  Lines        1683     1726      +43     
==========================================
+ Hits         1611     1655      +44     
+ Misses         72       71       -1     
Impacted Files Coverage Δ
graphene/__init__.py 100.00% <ø> (ø)
graphene/relay/__init__.py 100.00% <100.00%> (ø)
graphene/relay/id_type.py 100.00% <100.00%> (ø)
graphene/relay/node.py 100.00% <100.00%> (+1.38%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 15 '22 12:09 codecov[bot]

@ulgens I have rebased on master and added a few tests to get full coverage. Do you mind double checking and approving so I can merge?

tcleonard avatar Sep 15 '22 12:09 tcleonard