graphene icon indicating copy to clipboard operation
graphene copied to clipboard

Published 20 hours ago • verified publisher icon graphql-python

Fixing a Type Warning as per #1100

Open evank28 opened this issue 5 years ago • 1 comments

Fixing a Type Warning that resolves #1100 for PyCharm IDE users.

evank28 avatar Nov 14 '20 00:11 evank28

should it be Optional[Type[ObjectType]]? None seems to be an acceptable value.

skewty avatar Nov 27 '20 02:11 skewty

We should fix all type hints and switch to this: https://github.com/tox-dev/sphinx-autodoc-typehints

@skewty is right, Query should be optional. See types/schema.py:107 and graphql-core/type/schema.py:95. Closing this, as single-line type hint corrections don't solve the overall problem. PRs should be at least on a per-file basis to ensure we are not skimming through every file twice.

erikwrede avatar Aug 27 '22 17:08 erikwrede