graphene-sqlalchemy icon indicating copy to clipboard operation
graphene-sqlalchemy copied to clipboard

WIP: feat: Add contains_exactly filter

Open sabard opened this issue 2 years ago • 1 comments

The contains_exactly filter implements relational division, essentially finding entities related to those specified exactly by a search criteria. That is, found entities should have no relations not specified by the search criteria.

contains_exactly was not working with async sqlalchemy 1.4 and was holding up #357, so it was removed. This PR adds back the feature.

sabard avatar Apr 24 '23 17:04 sabard

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 93.13%. Comparing base (a03a8b1) to head (736f10d). Report is 116 commits behind head on add-filters.

Files Patch % Lines
graphene_sqlalchemy/filters.py 13.33% 13 Missing :warning:
Additional details and impacted files
@@               Coverage Diff               @@
##           add-filters     #391      +/-   ##
===============================================
- Coverage        96.37%   93.13%   -3.25%     
===============================================
  Files                9       10       +1     
  Lines              773     1296     +523     
===============================================
+ Hits               745     1207     +462     
- Misses              28       89      +61     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 24 '23 17:04 codecov[bot]