String ID

[adrianschneider94]

Not only ints should be converted to the ID type, but also strings. Especially as GraphQL itself considers IDs as strings.

@convert_sqlalchemy_type.register(types.String)
@convert_sqlalchemy_type.register(types.SmallInteger)
@convert_sqlalchemy_type.register(types.Integer)
def convert_column_to_int_or_id(type, column, registry=None):
    return ID if column.primary_key else String

[jnak]

I agree with this. I'm happy to revisit this when tacking https://github.com/graphql-python/graphene-sqlalchemy/issues/102. Feel free to share your opinion in the other thread if you want to help move this forward. Cheers

[erikwrede]

Will try this out while testing graphene#1428