graphene-federation icon indicating copy to clipboard operation
graphene-federation copied to clipboard

Add new line before field description

Open emilkholod opened this issue 2 years ago • 3 comments

If we will generate SDL schema then we get:

"""Desc 1"""
type Object1 @key(fields: "field1") {
  """Desc field 1"""
  field1: DateTime
  """Desc field 2"""
  field2: ID
  """Desc field 3"""
  field3: String
  field4: String
  field5: String
}

but by default there should be a new line before descriptions:

"""Desc 1"""
type Object1 @key(fields: "field1") {
  """Desc field 1"""
  field1: DateTime

  """Desc field 2"""
  field2: ID

  """Desc field 3"""
  field3: String
  field4: String
  field5: String
}

emilkholod avatar May 24 '23 11:05 emilkholod

Can anybody check this PR please?

emilkholod avatar May 29 '23 07:05 emilkholod

Hey there, I'll check it out more closely this week.

erikwrede avatar May 30 '23 14:05 erikwrede

Pull Request Test Coverage Report for Build 5068006418

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 90.553%

Changes Missing Coverage Covered Lines Changed/Added Lines %
graphene_federation/service.py 2 3 66.67%
<!-- Total: 2 3
Totals Coverage Status
Change from base Build 5063747249: -0.2%
Covered Lines: 393
Relevant Lines: 434

💛 - Coveralls

coveralls avatar Apr 30 '24 06:04 coveralls