graphql-voyager icon indicating copy to clipboard operation
graphql-voyager copied to clipboard

NPM 2.0.0 version has major code problems

Open IvanSereginGitHub opened this issue 2 years ago • 1 comments
trafficstars

render-voyager-page.js has window.addEventListener('load') with SYNC function trying to call ASYNC method (await response.json()). Not only that but await response.json() CANNOT be called like that since response is still a PROMISE, not a result object, therefore it should be either (await response).json() or it should be done SYNCHRONOUSLY. And even after all that fixed manually, I still couldn't get past the "Loading..." because of "GraphQLVoyager.init is not a function".

Didn't test previous versions, so can't say anything about them. Please fix NPM 2.0.0 version, considering those problems - I doubt that it was tested at all...

IvanSereginGitHub avatar Oct 11 '23 09:10 IvanSereginGitHub

Related: https://github.com/graphql-kit/graphql-voyager/issues/372

mnlbox avatar Oct 19 '23 00:10 mnlbox