graphql_devise icon indicating copy to clipboard operation
graphql_devise copied to clipboard

When do you plan on supporting rails 7

Open maszuDEV opened this issue 3 years ago • 10 comments

Question

Hello everyone! Do you know when rails 7 support will be added?

Best,

maszuDEV avatar Jan 13 '22 10:01 maszuDEV

Hey, @maszuDEV! We still depend on this PR getting into a DTA release, before we can release a new version that supports Rails 7.0. Master already supports Rails 7.0 and everything seems to work fine. We are just getting an error on the generator specs and we need to look into that. So if you want to give it a try, you can use this gem's and DTA's master branch on your gemfile. Hopefully we can release a new version soon.

mcelicalderon avatar Jan 13 '22 17:01 mcelicalderon

@mcelicalderon thanks for the answer! Then it's best to wait to upgrade as well.

maszuDEV avatar Jan 16 '22 10:01 maszuDEV

Test matrix already includes Rails 7.0 and everything looks fine. We still need to wait for DTA to release a new version https://github.com/lynndylanhurley/devise_token_auth/pull/1517#issuecomment-1003751213

mcelicalderon avatar Jan 25 '22 14:01 mcelicalderon

The gem seems to support Rails 7 now, but it's missing in the current release?

image

openscript avatar Jun 11 '22 09:06 openscript

Hey @openscript! As stated in https://github.com/graphql-devise/graphql_devise/issues/207#issuecomment-1021243045 DTA is one of the main dependencies of this gem and they still haven't released a version that supports rails 7. Support for rails 7 is already merged into master for both DTA and this gem, but we cannot release a version with support for that until they do first. I wouldn't recommend in production, but you can use this gem with DTA both in master and it should work with rails 7. See possible issues with doing that in https://github.com/lynndylanhurley/devise_token_auth/pull/1517#issuecomment-1003751213

mcelicalderon avatar Jun 11 '22 18:06 mcelicalderon

@mcelicalderon Thank you very much for explaining :)

openscript avatar Jun 11 '22 20:06 openscript

Hey @openscript! As stated in #207 (comment) DTA is one of the main dependencies of this gem and they still haven't released a version that supports rails 7. Support for rails 7 is already merged into master for both DTA and this gem, but we cannot release a version with support for that until they do first. I wouldn't recommend in production, but you can use this gem with DTA both in master and it should work with rails 7. See possible issues with doing that in lynndylanhurley/devise_token_auth#1517 (comment)

Hi @mcelicalderon, do I understand correctly that the current master will no longer work with rails 7? Best,

maszuDEV avatar Aug 08 '22 19:08 maszuDEV

@maszuDEV yes, we removed support from master in order to make the release process easier. We don't have a good estimate on when DTA will release a version that supports Rails 7. When they do, it will be very simple here to add back the support. In the mean time if you were already using master to get Rails 7 support, I would recommend looking at this commit https://github.com/graphql-devise/graphql_devise/commit/f6435cf8486c8854d6c9034c3637a1ff37c6c194 if you need to add it back, perhaps we can create a separate branch with that if it will help you

mcelicalderon avatar Aug 10 '22 19:08 mcelicalderon

@maszuDEV, created https://github.com/graphql-devise/graphql_devise/tree/rails-7-support to keep support for Rails 7 in a branch

mcelicalderon avatar Aug 12 '22 04:08 mcelicalderon

@maszuDEV, created https://github.com/graphql-devise/graphql_devise/tree/rails-7-support to keep support for Rails 7 in a branch

thank you very much ❤️

maszuDEV avatar Aug 12 '22 08:08 maszuDEV

DTA v1.2.1 was just released with Rails 7!

CodySwannGT avatar Sep 15 '22 02:09 CodySwannGT

Whaaat? That's awesome. Thank you for the ping, @CodySwannGT! I'm on it

mcelicalderon avatar Sep 15 '22 02:09 mcelicalderon

Closing this one as v1.1.0 was released. Thank you all for your patience!

mcelicalderon avatar Sep 15 '22 15:09 mcelicalderon

@mcelicalderon Thank you for acting so quickly and all your work on this project!!!

openscript avatar Sep 15 '22 16:09 openscript

Since master and the released version already support rails 7, please stop using the branch https://github.com/graphql-devise/graphql_devise/tree/rails-7-support so I can remove it in the near future

mcelicalderon avatar Sep 15 '22 16:09 mcelicalderon