graph-tooling icon indicating copy to clipboard operation
graph-tooling copied to clipboard

Feature | `graph init` Add support to download spkg files from spkg.io

Open joshuanazareth97 opened this issue 1 year ago • 6 comments

Change Description

  • Allow passing a file url for spkg files instead of just a file path.
  • Download the file if a url has been passed

Related Issue / Discussion

https://github.com/graphprotocol/graph-tooling/issues/1641

Screenshot of change

image image image

joshuanazareth97 avatar Apr 26 '24 18:04 joshuanazareth97

🦋 Changeset detected

Latest commit: 7d24759e9e6a91e3b42d787b4c538ce9513971af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 26 '24 18:04 changeset-bot[bot]

Hi @saihaj can you please review this PR? Let me know if there's anything you need me to do before you merge it. Thanks!

joshuanazareth97 avatar May 01 '24 06:05 joshuanazareth97

thanks @joshuanazareth97 sorry for the delay. I was away on vacation last week, catching up on things will try to land this early next week

saihaj avatar May 02 '24 18:05 saihaj

@joshuanazareth97 are you still working on this?

saihaj avatar May 15 '24 01:05 saihaj

@joshuanazareth97 are you still working on this?

@saihaj apologies, was occupied with some other stuff last week. Have addressed all your comments.

joshuanazareth97 avatar May 15 '24 04:05 joshuanazareth97

@saihaj is there anything else you need me to do here? Can we merge this PR if the changes are made to your satisfaction?

joshuanazareth97 avatar May 28 '24 14:05 joshuanazareth97