graph-node icon indicating copy to clipboard operation
graph-node copied to clipboard

Track DIPS gas metrics in csv

Open incrypto32 opened this issue 1 year ago • 1 comments

incrypto32 avatar Feb 19 '24 12:02 incrypto32

Lets use object-store, instead of cloud-storage, it supports multiple cloud providers and very importantly supports local files.

leoyvens avatar Feb 22 '24 14:02 leoyvens

What if we left GasMetrics as it was, since those Prometheus metrics may be useful for other purposes. And then added this new collector under the BlockState? From a Rust ownership perspective it may be nicer, we may be able to avoid the locks, and have flush_metrics_to_store consume self, such that fn reset_counters wouldn't be necessary.

leoyvens avatar Mar 12 '24 12:03 leoyvens

I don't know if one file per block will be ok or not, but we can move forward with this and evaluate after testing a bit in real-life scenarios.

leoyvens avatar Mar 19 '24 12:03 leoyvens