graph-node icon indicating copy to clipboard operation
graph-node copied to clipboard

refactor: extract graphman core functions

Open YassinEldeeb opened this issue 2 years ago • 5 comments

YassinEldeeb avatar May 16 '23 10:05 YassinEldeeb

@YassinEldeeb Do you have the schema for the GraphQL server this generates somewhere? It would help in reviewing these changes.

lutter avatar Aug 23 '23 18:08 lutter

@YassinEldeeb Do you have the schema for the GraphQL server this generates somewhere? It would help in reviewing these changes.

Hey! Yes we can emit a GraphQL SDL file, but there's no graphql included in this PR, this only targets extracting graphman commands into core functions which can be later used by graphman API which is in this main PR #4598, the above is only a part of it.

YassinEldeeb avatar Nov 03 '23 09:11 YassinEldeeb

Could you also try and rebase the PR on top of latest master? Can you also format the commit messages in accordance with CONTRIBUTING.md ?

I rebased and squashed my commits following the contribution guide.

YassinEldeeb avatar Nov 03 '23 09:11 YassinEldeeb

This pull request hasn't had any activity for the last 90 days. If there's no more activity over the course of the next 14 days, it will automatically be closed.

github-actions[bot] avatar Feb 20 '24 00:02 github-actions[bot]

hey @YassinEldeeb checking in on this?

azf20 avatar Feb 20 '24 10:02 azf20

Closing this since it's not been active for a while. Feel free to reopen when you're ready to work on this again

lutter avatar Apr 08 '24 16:04 lutter