graph-node icon indicating copy to clipboard operation
graph-node copied to clipboard

store/postgres: warn if locale is not en_US.utf8

Open saihaj opened this issue 3 years ago • 3 comments
trafficstars

Check for user's locale on startup and if it is not en_US.utf8 panic.

Closes #3118

saihaj avatar Jun 15 '22 19:06 saihaj

We need a guide for what an indexer should do when encountering this error, and the error message should link to that guide.

leoyvens avatar Jun 17 '22 14:06 leoyvens

@saihaj from discussion with @leoyvens , I think we may want to make the error message a bit more informative (i.e. directing the user to change their DB locale to match, or change the env variable)

azf20 avatar Jul 12 '22 12:07 azf20

Here's how I think we should try and manage using the same locale for all indexers. We'll probably be stuck on en_US.UTF-8 because there are fewer indexers that need to change, though C would be more preferable for performance.

  1. Communicate a timeline and some writeup on what indexers need to do
  2. Print a warning when the locale is not the specified one for a while (probably months, definitely two releases)
  3. Switch to enforce the locale, i.e., the current behavior of panicking on startup

lutter avatar Jul 19 '22 15:07 lutter

This pull request hasn't had any activity for the last 90 days. If there's no more activity over the course of the next 14 days, it will automatically be closed.

github-actions[bot] avatar Nov 17 '22 00:11 github-actions[bot]

https://github.com/graphprotocol/graph-node/pull/4163

saihaj avatar Nov 17 '22 09:11 saihaj