common-ts icon indicating copy to clipboard operation
common-ts copied to clipboard

[db] add ability to enable SSL for database connection

Open drew-u410 opened this issue 1 year ago • 1 comments

  • Adds the ability to enable SSL for the database connection.
  • Maintains existing default behavior of not being enabled.
  • Adds tests for setting options and default options on the database connection.

--

Ran tests locally and they pass as expected:

$ POSTGRES_TEST_DATABASE=test POSTGRES_TEST_PASSWORD=test POSTGRES_TEST_USERNAME=test POSTGRES_TEST_HOST=localhost yarn test

Once this is merged, I intend to open PRs for graphprotocol/indexer to update if accepted.

Thank you.

drew-u410 avatar Aug 13 '24 15:08 drew-u410

LGTM 👍 Thanks for the contribution, @drew-u410!

Np- do you intend to merge? If so, on what timeline? I would like to prepare an indexer MR but I can't do so until this is able to be used.

drew-u410 avatar Sep 04 '24 13:09 drew-u410

I've put up a version bump PR https://github.com/graphprotocol/common-ts/pull/122 which will include this.

dwerner avatar Oct 28 '24 15:10 dwerner

I've put up a version bump PR #122 which will include this.

Thank you very much. I have the indexer MR just about ready.

drew-u410 avatar Oct 28 '24 15:10 drew-u410