Beanconqueror
Beanconqueror copied to clipboard
Refactor/sonar issues
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: capitantrueno
:x: Mario Rodrigo
Mario Rodrigo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Hey there! Thanks for your support @capitantrueno realy appreciate it! I'm over the pull request, please make sure to go against the develop branch after its more accurate then the master. Also I needed to do a emergency release, so please pull again :) Thanks Lars
Thanks @graphefruit ! Next time I will PR to develop instead of master. Regards, Mario.
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Hey @capitantrueno, could you please give me a ping when the PR is ready for you? I've left some comments, else I'd go for final review. Did you also try it out on your side?
Thanks Lars
Hi there! @graphefruit, I have just resolved the conflicts in the brew-add file. I think it is ready for merging. In the future, I will create the branch in your repository from develop. BR, Mario.
Sorry for taking so long to respond to your comments. I had limited access to email. R, Mario.