Beanconqueror icon indicating copy to clipboard operation
Beanconqueror copied to clipboard

Refactor/sonar issues

Open capitantrueno opened this issue 1 year ago • 2 comments

capitantrueno avatar Mar 23 '24 15:03 capitantrueno

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: capitantrueno
:x: Mario Rodrigo


Mario Rodrigo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 23 '24 15:03 CLAassistant

Hey there! Thanks for your support @capitantrueno realy appreciate it! I'm over the pull request, please make sure to go against the develop branch after its more accurate then the master. Also I needed to do a emergency release, so please pull again :) Thanks Lars

graphefruit avatar Mar 25 '24 20:03 graphefruit

Thanks @graphefruit ! Next time I will PR to develop instead of master. Regards, Mario.

capitantrueno avatar Mar 26 '24 06:03 capitantrueno

Hey @capitantrueno, could you please give me a ping when the PR is ready for you? I've left some comments, else I'd go for final review. Did you also try it out on your side?

Thanks Lars

graphefruit avatar Mar 28 '24 20:03 graphefruit

Hi there! @graphefruit, I have just resolved the conflicts in the brew-add file. I think it is ready for merging. In the future, I will create the branch in your repository from develop. BR, Mario.

capitantrueno avatar Mar 29 '24 10:03 capitantrueno

Sorry for taking so long to respond to your comments. I had limited access to email. R, Mario.

capitantrueno avatar Apr 06 '24 18:04 capitantrueno