python-sortedcontainers icon indicating copy to clipboard operation
python-sortedcontainers copied to clipboard

Include regression tests in PyPI tarball

Open kmosiejczuk opened this issue 6 years ago • 5 comments
trafficstars

Include regression tests in PyPI tarball for easy regression testing by distributors.

In OpenBSD we use regression tests to make sure nothing has been broken by changes in the main OS or updates of other ports. Having to pull tests from github rather than PyPI makes it harder to do those tests.

kmosiejczuk avatar Nov 08 '19 17:11 kmosiejczuk

Will this install the tests with the package? I don’t really want that. But if it’s just for distribution (like a tarball) then I suppose that’s fine.

grantjenks avatar Nov 08 '19 17:11 grantjenks

It shouldn't include them in the package. (OpenBSD's package, at least).

kmosiejczuk avatar Nov 08 '19 17:11 kmosiejczuk

I'm more concerned with whether the tests will be installed with the package from pypi. If someone does "$ pip install sortedcontainers" now does it include the tests? I'd like to avoid that.

grantjenks avatar Nov 10 '19 23:11 grantjenks

If someone does "$ pip install sortedcontainers" now does it include the tests?

It doesn't. ☺

jwilk avatar Nov 18 '19 08:11 jwilk

The 2.7 tests are failing because your checks are trying to use pytest 5.2.2. pytest dropped Python 2.7 support with 5.0. Pytest 4.6.6 is the most recent that still supports 2.7.

The 3.4 tests are failing because 3.4 doesn't have function typing, so needs to including the typing backport. It's not listed as needed because pytest 5.2.2 requires Python 3.5+

kmosiejczuk avatar Nov 18 '19 17:11 kmosiejczuk