gramps-web icon indicating copy to clipboard operation
gramps-web copied to clipboard

🩹 Fixing static app-title

Open letsjustfixit opened this issue 1 year ago • 3 comments

Fixing: that the AppBar has no access to the _dbInfo property so the app-title stays always static.

letsjustfixit avatar Nov 16 '24 03:11 letsjustfixit

That's true. Funnily enough, it's a leftover from the ancient Gramps Web app frontend (pre Gramps Web API), and I never bothered to change it (i.e. make it display the database name again) because I don't think it makes sense right now as long as we don't add the possibility to change the database name from the frontend. Many trees have names that are not really suitable as app header. So the to do list is

  • make database name changeable in Web API - this is already done, although I don't remember if it works only in the multi tree setup
  • make database name changeable in the frontend
  • leave one release (1 month) between this and changing the app header, to leave tree owners time to change

DavidMStraub avatar Nov 16 '24 16:11 DavidMStraub

Got it.

(For me this was essential because I have multiple trees served by the same instance and they even have some common people. I was even thinking about assigning different color schemes to trees to make it more obvious when working with the different trees in different browser windows at the same time. I've also added the current logged in username to the user settings screen above the logout to make it obvious which test user I'm logged in with. )

We could add an optional TREE_DISPLAY_NAME property that defaults to the existing tree name as TREE is an essential reference key and TREE_DISPLAY_NAME might contain special characters illedavised to use for a key / folder name(accented characters,, unicode special characters etc..) .

letsjustfixit avatar Nov 16 '24 19:11 letsjustfixit

I've also added the current logged in username to the user settings screen above the logout to make it obvious which test user I'm logged in with.

Yes, #376, urgently needed.

DavidMStraub avatar Nov 16 '24 20:11 DavidMStraub