Thomas Grainger

Currently the type annotation for this is bytes so I suspect this needs updating too Also I think this should be any bytes like object: https://docs.python.org/dev/glossary.html#term-bytes-like-object

@wongpat the fix is here https://github.com/twisted/twisted/compare/trunk...graingert:allow-all-readable-buffer-in-write but I can't push it to your PR because [you created this PR from the default branch of your repository](https://blog.jasonmeridth.com/posts/do-not-issue-pull-requests-from-your-master-branch/)

You can pull my changes in yourself, or recreate the PR and I'll push them

it looks like there's something more fundamentally wrong with reusing-deferreds in coros: ```python from twisted.internet import defer, task class MyError(Exception): pass async def sleep(delay, result=None): from twisted.internet import reactor await...

so the problem is here: https://github.com/twisted/twisted/blob/5c24e99e671c4082a1ddc8dbeb869402294bd0dc/src/twisted/internet/defer.py#L1670-L1679 when you await a Deferred you expect the result to be cleared as a result of `gotBoth` returning None. However there's two ways to...

> W504 line break after binary operator > W503 line break before binary operator These should be handled by black and ignored in pycodestyle because we use it via flake8...

@ljharb I'm not sure how to configure it exactly (I can't see anywhere where Chrome is selected as the only browser) Marking as WIP. > Also it'd be ideal to...

@ljharb can you jump through all the hoops for getting Browserstack for OSS?

@ljharb ah looks like karma tests are currently broken anyway. Will try again when they're working on master. And yes currently the tests try to run Firefox, Chrome and Phantom.

Currently RemovedIn8Warning is declared final, but really it should be sealed, because it means pytest can't create subclasses of RemovedIn8Warning, eg ReturnNotNoneWarning