grain icon indicating copy to clipboard operation
grain copied to clipboard

Tests: Make number tests use `isClose`

Open spotandjake opened this issue 1 year ago • 2 comments

There are a lot of cases in the Number libraries tests that we use < and then a > comparison to check approximate equal such as with gamma and trig functions. We should instead use the Number.isClose function.

Explanation: This will basically involve going through the Number.test.gr file and replacing any of the <, > tests that test it is within a range with isClose you will likely need to do a bit of research to find what the real number is and then tune absoluteTolerance and relativeTolerance

spotandjake avatar Feb 19 '24 00:02 spotandjake

I would love to pick this up if no one else has

AdemOdza avatar May 10 '24 04:05 AdemOdza

@AdemOdza Go for it!

ospencer avatar May 10 '24 20:05 ospencer