grain icon indicating copy to clipboard operation
grain copied to clipboard

Sys.process exit test shouldn't actually exit

Open phated opened this issue 3 years ago • 2 comments

We should use our "wasi polyfill" to test sys.process exit, which would allow this test to work on Windows (or a different wasm runtime).

phated avatar Apr 28 '22 16:04 phated

Just to clarify, switching to, say, WAMR, would cause the test to fail because we wouldn't be shelling out anymore (so we'd exit the current process, that being the tests themselves).

But of course we're going to avoid this entirely 😄

ospencer avatar Apr 28 '22 19:04 ospencer

This hasn't been solved for the wasm runtime case, but it is temporarily worked-around by #1223 (for our Windows testing needs)

phated avatar May 15 '22 22:05 phated