tempo icon indicating copy to clipboard operation
tempo copied to clipboard

chore: bump go module path

Open davidgiga1993 opened this issue 1 year ago • 8 comments

What this PR does: Changes the module path to match the major version, this resolves go get not working.

This change was based upon the changes required for the v3 loki release

Which issue(s) this PR fixes: Fixes #3817

Checklist

  • [x] Tests updated
  • [ ] Documentation added
  • [X] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

davidgiga1993 avatar Jul 31 '24 13:07 davidgiga1993

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 31 '24 13:07 CLAassistant

I just pulled the latest changes on main into this. As a merge conflict will arise from every new change on main it would be great if someone could provide feedback for this change, thanks!

davidgiga1993 avatar Aug 05 '24 06:08 davidgiga1993

Hi @davidgiga1993. Does this show up because you are vendoring Tempo somewhere? I remember seeing the Loki team made this change as you point out, but didn't follow the results closely to know how it went.

zalegrala avatar Aug 06 '24 13:08 zalegrala

@zalegrala yes we're trying to use Tempo as package for a custom reverse proxy to parse the AST of the query. We're doing the same thing with Prometheus and Loki (which can be consumed as a dependency)

davidgiga1993 avatar Aug 06 '24 14:08 davidgiga1993

This change seems reasonable to me. We hesitate because this will cause some additional work for us internally. However, it might be nice to get this in before 2.6. If this can get updated I can help review early next week.

zalegrala avatar Aug 15 '24 13:08 zalegrala

This change seems reasonable to me. We hesitate because this will cause some additional work for us internally. However, it might be nice to get this in before 2.6. If this can get updated I can help review early next week.

I've resolved the conflicts

davidgiga1993 avatar Aug 19 '24 09:08 davidgiga1993

And again

davidgiga1993 avatar Aug 20 '24 05:08 davidgiga1993

This PR has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. This pull request will be closed in 15 days if there is no new activity. Please apply keepalive label to exempt this Pull Request.

github-actions[bot] avatar Oct 20 '24 00:10 github-actions[bot]