tempo icon indicating copy to clipboard operation
tempo copied to clipboard

Allow grpc dial config for querier worker

Open zalegrala opened this issue 1 year ago • 4 comments
trafficstars

What this PR does:

Without this change, the querier worker does not honor the send/recv max message size.

Which issue(s) this PR fixes: Fixes #1596

Checklist

  • [ ] Tests updated
  • [ ] Documentation added
  • [ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

zalegrala avatar Dec 08 '23 13:12 zalegrala

We're setting these on the query frontend server. Does GRPC negotiate the settings between the 2? Did we see something that makes us think we should set this?

joe-elliott avatar Dec 12 '23 16:12 joe-elliott

I was reading in this area recently and also noticed the #1596 and thought to put up the PR. I think client and server settings are separate, and so without this, we are using the default values on the client. We could certainly do more testing to confirm, like clamping down the max bytes on the client and seeing if the server responds in a way that represents the negotiation.

zalegrala avatar Dec 12 '23 18:12 zalegrala

If we want to do this change, we should repro the issue and then confirm this fixes it.

joe-elliott avatar Dec 12 '23 19:12 joe-elliott

I mixed on this. Here we're only using the configuration that we already expose, so to test we'd be testing the deeper levels of gRPC. I haven't heard back on #1596.

zalegrala avatar Feb 08 '24 15:02 zalegrala

Withdrawing the PR.

zalegrala avatar Mar 14 '24 14:03 zalegrala