pyroscope-go icon indicating copy to clipboard operation
pyroscope-go copied to clipboard

feat: expose http.Client override through the main configuration

Open jqueuniet opened this issue 10 months ago • 3 comments

An override to the remote http.Client has been added to the remote configuration with PR #101 , but using it seems to require reimplementing the Start function from the api package (unless I'm missing something). This PR adds an HTTPClient field to the main configuration struct to facilitate customization.

I guess there could be many different reasons to justify this, mine is to allow overriding the CA certificate store without rebuilding the system CA store, which can be difficult or even impossible in specific contexts.

jqueuniet avatar Jan 24 '25 15:01 jqueuniet

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 24 '25 15:01 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 24 '25 15:01 CLAassistant

what's happening with it?

natanoligo avatar Feb 26 '25 13:02 natanoligo