mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Helm: add commonLabels (#9067)

Open ftrigari opened this issue 1 year ago • 1 comments

What this PR does

Every object created by the chart could have custom labels.

Which issue(s) this PR fixes or relates to

Fixes #9067

Checklist

  • [ ] Tests updated.
  • [ ] Documentation added.
  • [ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [ ] about-versioning.md updated with experimental features.

ftrigari avatar Oct 26 '24 00:10 ftrigari

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 26 '24 00:10 CLAassistant

Hello @ftrigari . Thanks a lot for your contribution !

The proposed change looks good overall and makes sense. However, I noticed that the lint-helm check is currently failing. It seems this is due to the change introducing an empty line when no labels are provided.

Could you please address this issue to ensure the lint-helm check passes?

NickAnge avatar Dec 18 '24 16:12 NickAnge

Hi @NickAnge, I'm sorry but I messed up my fork 😓 I deleted all my old commits, updated the repo, committed my edited files, and then created a new PR. The new PR is https://github.com/grafana/mimir/pull/10385

ftrigari avatar Jan 09 '25 13:01 ftrigari