mimir Honor minio fullname

Honor minio fullname

Open elsoa-invitech opened this issue 1 year ago • 3 comments

the subchart full name override is not honored is referenced template files. (eg minio service name or configmap name)

Fixes #9564.

Oct 08 '24 11:10 elsoa-invitech

All committers have signed the CLA.

Oct 08 '24 11:10 CLAassistant

Solution from here: https://stackoverflow.com/a/69515809

Oct 08 '24 11:10 elsoa-invitech

The fix looks good to me. But I think there is one place in the changeset, that also needs fixing (refer to the in place comment).

Also, could you add a BUGFIX entry to the chart's CHANGELOG in the operations/helm/charts/mimir-distributed/CHANGELOG.md file.

Oct 25 '24 20:10 narqo

anyway, what do you think: in values.yaml mimir config endpoint sould use {{ .Values.minio.service.port }} instead of 9000?

Oct 28 '24 11:10 elsoa-invitech

in values.yaml mimir config endpoint sould use {{ .Values.minio.service.port }} instead of 9000?

That's a great point, thank you. Fixing it should be a noop for the chart and its tests so if you could fix the values here, that'd be nice.

Oct 29 '24 09:10 narqo

Changed the port to minio.service values

Oct 29 '24 12:10 elsoa-invitech