fullnameOverride mixing in helm subcharts

[elsoa-invitech]

Describe the bug

If you set the fullnameOverride for mimir and for subcharts, some manifests are generated bad.

To Reproduce

Sample values.yaml:

---
fullnameOverride: grafana-mimir
minio:
  fullnameOverride: grafana-mimir-minio

Generate the manifest: helm template --dry-run --debug -f values.yaml --repo https://grafana.github.io/helm-charts mimir-distributed --name-template csiga --output-dir out

Check the main templates, its good:

$ grep " name:" out/mimir-distributed/templates/runtime-configmap.yaml 
  name: grafana-mimir-runtime

Check a minio template, its good:

$ grep " name:" out/mimir-distributed/charts/minio/templates/configmap.yaml 
  name: grafana-mimir-minio

But some template have bad reference, like:

$ grep -A1 configMap out/mimir-distributed/templates/minio/create-bucket-job.yaml 
            - configMap:
                name: csiga-minio

Expected behavior

create-bucket-job.yaml sould have configmap name: grafana-mimir-minio

Environment

• Infrastructure: kubernetes
• Deployment tool: helm

[elsoa-invitech]

Same issue exist in minio service ref: This is the minio service name:

$ grep " name:" out/mimir-distributed/charts/minio/templates/service.yaml 
  name: grafana-mimir-minio

And the mimir-config endpoint is wrong:

$ grep csiga- out -R
out/mimir-distributed/templates/mimir-config.yaml:        endpoint: csiga-minio.default.svc:9000
out/mimir-distributed/templates/mimir-config.yaml:        endpoint: csiga-minio.default.svc:9000
out/mimir-distributed/templates/mimir-config.yaml:        endpoint: csiga-minio.default.svc:9000

This sould be grafana-mimir-minio.default.svc