mimir icon indicating copy to clipboard operation
mimir copied to clipboard

feat: servicemonitor in jsonnet deployment

Open jouve opened this issue 2 years ago • 3 comments

What this PR does

add a servicemonitor to the jsonnet deployment.

it already exists for the chart (example: https://github.com/grafana/mimir/blob/80ee3c17ee134541904fcefc7e9b066b6288348d/operations/helm/charts/mimir-distributed/templates/query-scheduler/query-scheduler-servmon.yaml#L2)

the implementation is very similar to the one found in loki: https://github.com/grafana/loki/blob/main/production/ksonnet/loki/servicemonitor.libsonnet

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • [ ] Tests updated
  • [ ] Documentation added
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

jouve avatar Oct 08 '23 19:10 jouve

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 08 '23 19:10 CLAassistant

I applied @pracucci suggestions and rebased on top of main to remove the conflict in the changelog

jouve avatar Oct 18 '23 18:10 jouve

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

leizor avatar Nov 28 '23 22:11 leizor

Thank you for your contribution. This pull request has been marked as stale because it has had no activity in the last 150 days. It will be closed in 30 days if there is no further activity. If you need more time, you can add a comment to the PR.

github-actions[bot] avatar Jan 08 '25 02:01 github-actions[bot]

This pull request has been closed because it has been stale for 30 days with no activity. Feel free to reopen if you want to continue working on this.

github-actions[bot] avatar Feb 08 '25 02:02 github-actions[bot]