mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Helm: apply clusterLabel to k8s ServiceMonitors

Open thinkmassive opened this issue 2 years ago • 1 comments

What this PR does

Applies metaMonitoring.serviceMonitor.clusterLabel to ServiceMonitors for kube-state-metrics and kubelet-cadvisor. This is consistent with the template used to manage Mimir ServiceMonitors.

Which issue(s) this PR fixes or relates to

Fixes #2084 (follow-up to #2125)

Checklist

  • [x] Tests updated
  • [ ] ~Documentation added~ (n/a, docs already correct)
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

thinkmassive avatar Feb 01 '23 07:02 thinkmassive

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 01 '23 07:02 CLAassistant

Hey @dimitarvdimitrov thanks for the review! It's rebased and changelog is updated.

thinkmassive avatar Mar 07 '23 22:03 thinkmassive