mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Docs: Add Documentation to do HA deduplication on Mimir Helm Deployment

Open lamida opened this issue 3 years ago • 4 comments

What this PR does

Add Documentation to do HA deduplication on Mimir Helm Deployment.

Which issue(s) this PR fixes or relates to

Fixes #2597

Checklist

  • [ ] Tests updated
  • [X] Documentation added
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

lamida avatar Sep 16 '22 19:09 lamida

@krajorama please help to do another pass when you are free. I will unset draft from this PR too now.

Changes from your first pass:

  • Removed install mimir step and make mimir installated as prerequisite
  • Because reference to install mimir is removed therefore I don't see it makes sense to keep Prometheus helm install guide too
  • Removed grafana port forwarding and data source setup
  • Added Grafana agent setup (although the config and setup are exactly same like Prometheus)

lamida avatar Sep 19 '22 14:09 lamida

The image docs/sources/operators-guide/configure/setting-helm-ha-deduplication-consul/verify-deduplication.png is unreadable. Do you have one that has higher readability?

osg-grafana avatar Oct 06 '22 09:10 osg-grafana

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

pracucci avatar Oct 07 '22 09:10 pracucci

The image docs/sources/operators-guide/configure/setting-helm-ha-deduplication-consul/verify-deduplication.png is unreadable. Do you have one that has higher readability?

I updated the image with a higher resolution

lamida avatar Oct 11 '22 04:10 lamida

This is looking good to me now overall. I wonder where to add some information about using sharding in prometheus operator that I discovered during a support case: https://github.com/grafana/support-escalations/issues/4030#issuecomment-1262289642
I'm fine to add it in a separate PR though after we merge this.

krajorama avatar Oct 18 '22 15:10 krajorama

This is looking good to me now overall. I wonder where to add some information about using sharding in prometheus operator that I discovered during a support case: https://github.com/grafana/support-escalations/issues/4030#issuecomment-1262289642
I'm fine to add it in a separate PR though after we merge this.

Yes most likely it is better to be covered in separate PR. I am still more than happy to work on that.

lamida avatar Oct 19 '22 17:10 lamida