Support for rollout-operator and Zone Awareness

[krajorama]

What this PR does

Replication zone support for alertmanager, ingester, store-gateway component Including migration path, tests and documentation.

The migration is written in a way so that:

1. step sets the final configuration in the Mimir YAML configuration

• this means it can be validated right at the start
• subsequent steps alter CLI options , only restart what's necessary

2. steps are using named toggles, I realized that a single number would be too hard for us to maintain.

Which issue(s) this PR fixes or relates to

Fixes #2020

Checklist

• [ ] Tests updated
• [x] Documentation added
• [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2891739198

Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
diff -r -u -N scratch/./helm/07-config/mimir-curler-Deployment.yml scratch/./jsonnet/08-config/mimir-curler-Deployment.yml
--- scratch/./helm/07-config/mimir-curler-Deployment.yml	2022-08-19 19:38:56.954981739 +0000
+++ scratch/./jsonnet/08-config/mimir-curler-Deployment.yml	1970-01-01 00:00:00.000000000 +0000
@@ -1,37 +0,0 @@
----
-apiVersion: apps/v1
-kind: Deployment
-metadata:
-  generation: 1
-  name: mimir-curler
-  namespace: default
-spec:
-  progressDeadlineSeconds: 600
-  revisionHistoryLimit: 10
-  selector: {}
-  strategy:
-    rollingUpdate: {}
-    type: RollingUpdate
-  template:
-    metadata:
-      namespace: default
-    spec:
-      affinity:
-        podAntiAffinity: {}
-      containers:
-        - command:
-            - sh
-          imagePullPolicy: IfNotPresent
-          name: mimir
-          readinessProbe:
-            httpGet:
-              port: http-metrics
-          terminationMessagePath: /dev/termination-log
-          terminationMessagePolicy: File
-      dnsPolicy: ClusterFirst
-      restartPolicy: Always
-      schedulerName: default-scheduler
-      volumes: []
-  updateStrategy:
-    rollingUpdate: {}
-status: {}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2892323412

Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
diff -r -u -N scratch/./helm/07-config/alertmanager-MimirConfig.yml scratch/./jsonnet/08-config/alertmanager-MimirConfig.yml
--- scratch/./helm/07-config/alertmanager-MimirConfig.yml	2022-08-19 21:46:55.495189438 +0000
+++ scratch/./jsonnet/08-config/alertmanager-MimirConfig.yml	2022-08-19 21:47:04.467267082 +0000
@@ -542,7 +542,7 @@
     packet_write_timeout: 5s (default)
     pull_push_interval: 30s (default)
     randomize_node_name: true (default)
-    rejoin_interval: 1m30s
+    rejoin_interval: 0s (default)
     retransmit_factor: 4 (default)
     stream_timeout: 10s (default)
     tls_ca_path: ' (default)'
diff -r -u -N scratch/./helm/07-config/compactor-MimirConfig.yml scratch/./jsonnet/08-config/compactor-MimirConfig.yml
--- scratch/./helm/07-config/compactor-MimirConfig.yml	2022-08-19 21:46:55.499189473 +0000
+++ scratch/./jsonnet/08-config/compactor-MimirConfig.yml	2022-08-19 21:47:04.471267117 +0000
@@ -542,7 +542,7 @@
     packet_write_timeout: 5s (default)
     pull_push_interval: 30s (default)
     randomize_node_name: true (default)
-    rejoin_interval: 1m30s
+    rejoin_interval: 0s (default)
     retransmit_factor: 4 (default)
     stream_timeout: 10s (default)
     tls_ca_path: ' (default)'
diff -r -u -N scratch/./helm/07-config/distributor-MimirConfig.yml scratch/./jsonnet/08-config/distributor-MimirConfig.yml
--- scratch/./helm/07-config/distributor-MimirConfig.yml	2022-08-19 21:46:55.503189507 +0000
+++ scratch/./jsonnet/08-config/distributor-MimirConfig.yml	2022-08-19 21:47:04.479267185 +0000
@@ -597,7 +597,7 @@
     packet_write_timeout: 5s (default)
     pull_push_interval: 30s (default)
     randomize_node_name: true (default)
-    rejoin_interval: 1m30s
+    rejoin_interval: 0s (default)
     retransmit_factor: 4 (default)
     stream_timeout: 10s (default)
     tls_ca_path: ' (default)'
diff -r -u -N scratch/./helm/07-config/ingester-MimirConfig.yml scratch/./jsonnet/08-config/ingester-MimirConfig.yml
--- scratch/./helm/07-config/ingester-MimirConfig.yml	2022-08-19 21:46:55.507189542 +0000
+++ scratch/./jsonnet/08-config/ingester-MimirConfig.yml	2022-08-19 21:47:04.483267219 +0000
@@ -598,7 +598,7 @@
     packet_write_timeout: 5s (default)
     pull_push_interval: 30s (default)
     randomize_node_name: true (default)
-    rejoin_interval: 1m30s
+    rejoin_interval: 0s (default)
     retransmit_factor: 4 (default)
     stream_timeout: 10s (default)
     tls_ca_path: ' (default)'
diff -r -u -N scratch/./helm/07-config/mimir-curler-Deployment.yml scratch/./jsonnet/08-config/mimir-curler-Deployment.yml
--- scratch/./helm/07-config/mimir-curler-Deployment.yml	2022-08-19 21:46:55.483189334 +0000
+++ scratch/./jsonnet/08-config/mimir-curler-Deployment.yml	1970-01-01 00:00:00.000000000 +0000
@@ -1,37 +0,0 @@
----
-apiVersion: apps/v1
-kind: Deployment
-metadata:
-  generation: 1
-  name: mimir-curler
-  namespace: default
-spec:
-  progressDeadlineSeconds: 600
-  revisionHistoryLimit: 10
-  selector: {}
-  strategy:
-    rollingUpdate: {}
-    type: RollingUpdate
-  template:
-    metadata:
-      namespace: default
-    spec:
-      affinity:
-        podAntiAffinity: {}
-      containers:
-        - command:
-            - sh
-          imagePullPolicy: IfNotPresent
-          name: mimir
-          readinessProbe:
-            httpGet:
-              port: http-metrics
-          terminationMessagePath: /dev/termination-log
-          terminationMessagePolicy: File
-      dnsPolicy: ClusterFirst
-      restartPolicy: Always
-      schedulerName: default-scheduler
-      volumes: []
-  updateStrategy:
-    rollingUpdate: {}
-status: {}
diff -r -u -N scratch/./helm/07-config/querier-MimirConfig.yml scratch/./jsonnet/08-config/querier-MimirConfig.yml
--- scratch/./helm/07-config/querier-MimirConfig.yml	2022-08-19 21:46:55.515189611 +0000
+++ scratch/./jsonnet/08-config/querier-MimirConfig.yml	2022-08-19 21:47:04.495267321 +0000
@@ -618,7 +618,7 @@
     packet_write_timeout: 5s (default)
     pull_push_interval: 30s (default)
     randomize_node_name: true (default)
-    rejoin_interval: 1m30s
+    rejoin_interval: 0s (default)
     retransmit_factor: 4 (default)
     stream_timeout: 10s (default)
     tls_ca_path: ' (default)'
diff -r -u -N scratch/./helm/07-config/query-scheduler-MimirConfig.yml scratch/./jsonnet/08-config/query-scheduler-MimirConfig.yml
--- scratch/./helm/07-config/query-scheduler-MimirConfig.yml	2022-08-19 21:46:55.527189716 +0000
+++ scratch/./jsonnet/08-config/query-scheduler-MimirConfig.yml	2022-08-19 21:47:04.503267390 +0000
@@ -542,7 +542,7 @@
     packet_write_timeout: 5s (default)
     pull_push_interval: 30s (default)
     randomize_node_name: true (default)
-    rejoin_interval: 1m30s
+    rejoin_interval: 0s (default)
     retransmit_factor: 4 (default)
     stream_timeout: 10s (default)
     tls_ca_path: ' (default)'
diff -r -u -N scratch/./helm/07-config/ruler-MimirConfig.yml scratch/./jsonnet/08-config/ruler-MimirConfig.yml
--- scratch/./helm/07-config/ruler-MimirConfig.yml	2022-08-19 21:46:55.531189750 +0000
+++ scratch/./jsonnet/08-config/ruler-MimirConfig.yml	2022-08-19 21:47:04.507267424 +0000
@@ -618,7 +618,7 @@
     packet_write_timeout: 5s (default)
     pull_push_interval: 30s (default)
     randomize_node_name: true (default)
-    rejoin_interval: 1m30s
+    rejoin_interval: 0s (default)
     retransmit_factor: 4 (default)
     stream_timeout: 10s (default)
     tls_ca_path: ' (default)'
diff -r -u -N scratch/./helm/07-config/store-gateway-MimirConfig.yml scratch/./jsonnet/08-config/store-gateway-MimirConfig.yml
--- scratch/./helm/07-config/store-gateway-MimirConfig.yml	2022-08-19 21:46:55.539189820 +0000
+++ scratch/./jsonnet/08-config/store-gateway-MimirConfig.yml	2022-08-19 21:47:04.511267458 +0000
@@ -589,7 +589,7 @@
     packet_write_timeout: 5s (default)
     pull_push_interval: 30s (default)
     randomize_node_name: true (default)
-    rejoin_interval: 1m30s
+    rejoin_interval: 0s (default)
     retransmit_factor: 4 (default)
     stream_timeout: 10s (default)
     tls_ca_path: ' (default)'

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2903021973

Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
diff -r -u -N scratch/./helm/07-config/mimir-curler-Deployment.yml scratch/./jsonnet/08-config/mimir-curler-Deployment.yml
--- scratch/./helm/07-config/mimir-curler-Deployment.yml	2022-08-22 10:10:38.224832371 +0000
+++ scratch/./jsonnet/08-config/mimir-curler-Deployment.yml	1970-01-01 00:00:00.000000000 +0000
@@ -1,37 +0,0 @@
----
-apiVersion: apps/v1
-kind: Deployment
-metadata:
-  generation: 1
-  name: mimir-curler
-  namespace: default
-spec:
-  progressDeadlineSeconds: 600
-  revisionHistoryLimit: 10
-  selector: {}
-  strategy:
-    rollingUpdate: {}
-    type: RollingUpdate
-  template:
-    metadata:
-      namespace: default
-    spec:
-      affinity:
-        podAntiAffinity: {}
-      containers:
-        - command:
-            - sh
-          imagePullPolicy: IfNotPresent
-          name: mimir
-          readinessProbe:
-            httpGet:
-              port: http-metrics
-          terminationMessagePath: /dev/termination-log
-          terminationMessagePolicy: File
-      dnsPolicy: ClusterFirst
-      restartPolicy: Always
-      schedulerName: default-scheduler
-      volumes: []
-  updateStrategy:
-    rollingUpdate: {}
-status: {}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2903405631

Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
diff -r -u -N scratch/./helm/07-config/mimir-curler-Deployment.yml scratch/./jsonnet/08-config/mimir-curler-Deployment.yml
--- scratch/./helm/07-config/mimir-curler-Deployment.yml	2022-08-22 11:16:39.574779196 +0000
+++ scratch/./jsonnet/08-config/mimir-curler-Deployment.yml	1970-01-01 00:00:00.000000000 +0000
@@ -1,37 +0,0 @@
----
-apiVersion: apps/v1
-kind: Deployment
-metadata:
-  generation: 1
-  name: mimir-curler
-  namespace: default
-spec:
-  progressDeadlineSeconds: 600
-  revisionHistoryLimit: 10
-  selector: {}
-  strategy:
-    rollingUpdate: {}
-    type: RollingUpdate
-  template:
-    metadata:
-      namespace: default
-    spec:
-      affinity:
-        podAntiAffinity: {}
-      containers:
-        - command:
-            - sh
-          imagePullPolicy: IfNotPresent
-          name: mimir
-          readinessProbe:
-            httpGet:
-              port: http-metrics
-          terminationMessagePath: /dev/termination-log
-          terminationMessagePolicy: File
-      dnsPolicy: ClusterFirst
-      restartPolicy: Always
-      schedulerName: default-scheduler
-      volumes: []
-  updateStrategy:
-    rollingUpdate: {}
-status: {}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2977670209

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2978213269

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2978513055

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2978647469

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2978956626

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2980121392

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2998371437

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': accumulating resources: accumulation err='accumulating resources from '../01-ignore': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/01-ignore: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/01-ignore': accumulating resources: accumulation err='accumulating resources from '../00-base': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/00-base: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/00-base': Error: template: mimir-distributed/templates/store-gateway/store-gateway-svc.yaml:2:17: executing "mimir-distributed/templates/store-gateway/store-gateway-svc.yaml" at <include "mimir.zoneAwareReplicationMap" $args>: error calling include: template: mimir-distributed/templates/_helpers.tpl:445:28: executing "mimir.zoneAwareReplicationMap" at <$componentSection.zone_aware_replication.migration.enabled>: nil pointer evaluating interface {}.enabled

Use --debug flag to render out invalid YAML
: unable to run: 'helm template mimir --namespace default /home/runner/work/mimir/mimir/operations/helm/charts/mimir-distributed --values /tmp/kustomize-helm-2444120945/mimir-distributed-kustomize-values.yaml' with env=[HELM_CONFIG_HOME=/tmp/kustomize-helm-2444120945/helm HELM_CACHE_HOME=/tmp/kustomize-helm-2444120945/helm/.cache HELM_DATA_HOME=/tmp/kustomize-helm-2444120945/helm/.data] (is 'helm' installed?)

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/2998668390

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/3007524651

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/3013045141

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/3014159898

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/3014425906

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:warning: A difference was detected between the Helm chart and the Jsonnet library.

1. Use make check-helm-jsonnet-diff to reproduce the output locally.
2. This test is experimental while we gather feedback about its usefulness.
3. It does not block your PR from being merged, but we would appreciate you trying to keep feature parity between the Helm chart and Jsonnet library if possible.

If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag @Logiraptor so the Mimir maintainers can gather feedback later.

Please see the contribution docs here for more info.

Expand to see the output

Output of https://github.com/grafana/mimir/actions/runs/3014847598

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[osg-grafana]

Is the initial capped file name (operations/helm/charts/mimir-distributed/Chart.yaml) intentional for sorting reasons within a directory? If this is unintentional, change the file name to lowercase.

[krajorama]

Is the initial capped file name (operations/helm/charts/mimir-distributed/Chart.yaml) intentional for sorting reasons within a directory? If this is unintentional, change the file name to lowercase.

It must be named like this: https://helm.sh/docs/topics/charts/#the-chart-file-structure

[github-actions[bot]]

Helm <> Jsonnet Diff

:heavy_exclamation_mark: A difference was detected between the Helm chart and the Jsonnet library.

Please take a look and update one or both of the Helm chart and Jsonnet library to ensure feature parity. You can use make check-helm-jsonnet-diff to reproduce the issue locally. If you get stuck on this step, please ask the Mimir maintainers for help.

Please see the contribution docs here for more info.

Expand to see the full diff

Output of https://github.com/grafana/mimir/actions/runs/3050775179

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:heavy_exclamation_mark: A difference was detected between the Helm chart and the Jsonnet library.

Please take a look and update one or both of the Helm chart and Jsonnet library to ensure feature parity. You can use make check-helm-jsonnet-diff to reproduce the issue locally. If you get stuck on this step, please ask the Mimir maintainers for help.

Please see the contribution docs here for more info.

Expand to see the full diff

Output of https://github.com/grafana/mimir/actions/runs/3051180124

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:heavy_exclamation_mark: A difference was detected between the Helm chart and the Jsonnet library.

Please take a look and update one or both of the Helm chart and Jsonnet library to ensure feature parity. You can use make check-helm-jsonnet-diff to reproduce the issue locally. If you get stuck on this step, please ask the Mimir maintainers for help.

Please see the contribution docs here for more info.

Expand to see the full diff

Output of https://github.com/grafana/mimir/actions/runs/3051414714

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:heavy_exclamation_mark: A difference was detected between the Helm chart and the Jsonnet library.

Please take a look and update one or both of the Helm chart and Jsonnet library to ensure feature parity. You can use make check-helm-jsonnet-diff to reproduce the issue locally. If you get stuck on this step, please ask the Mimir maintainers for help.

Please see the contribution docs here for more info.

Expand to see the full diff

Output of https://github.com/grafana/mimir/actions/runs/3051579881

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:heavy_exclamation_mark: A difference was detected between the Helm chart and the Jsonnet library.

Please take a look and update one or both of the Helm chart and Jsonnet library to ensure feature parity. You can use make check-helm-jsonnet-diff to reproduce the issue locally. If you get stuck on this step, please ask the Mimir maintainers for help.

Please see the contribution docs here for more info.

Expand to see the full diff

Output of https://github.com/grafana/mimir/actions/runs/3051666395

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:heavy_exclamation_mark: A difference was detected between the Helm chart and the Jsonnet library.

Please take a look and update one or both of the Helm chart and Jsonnet library to ensure feature parity. You can use make check-helm-jsonnet-diff to reproduce the issue locally. If you get stuck on this step, please ask the Mimir maintainers for help.

Please see the contribution docs here for more info.

Expand to see the full diff

Output of https://github.com/grafana/mimir/actions/runs/3051753971

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:heavy_exclamation_mark: A difference was detected between the Helm chart and the Jsonnet library.

Please take a look and update one or both of the Helm chart and Jsonnet library to ensure feature parity. You can use make check-helm-jsonnet-diff to reproduce the issue locally. If you get stuck on this step, please ask the Mimir maintainers for help.

Please see the contribution docs here for more info.

Expand to see the full diff

Output of https://github.com/grafana/mimir/actions/runs/3052830585

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[github-actions[bot]]

Helm <> Jsonnet Diff

:heavy_exclamation_mark: A difference was detected between the Helm chart and the Jsonnet library.

Please take a look and update one or both of the Helm chart and Jsonnet library to ensure feature parity. You can use make check-helm-jsonnet-diff to reproduce the issue locally. If you get stuck on this step, please ask the Mimir maintainers for help.

Please see the contribution docs here for more info.

Expand to see the full diff

Output of https://github.com/grafana/mimir/actions/runs/3052985382

Error: accumulating resources: accumulation err='accumulating resources from '../06-pods': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/06-pods': accumulating resources: accumulation err='accumulating resources from '../05-services': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/05-services': accumulating resources: accumulation err='accumulating resources from '../04-memberlist': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/04-memberlist': accumulating resources: accumulation err='accumulating resources from '../03-labels': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/03-labels': accumulating resources: accumulation err='accumulating resources from '../02-configs-and-k8s-defaults': read /home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults: is a directory': recursed accumulation of path '/home/runner/work/mimir/mimir/operations/compare-helm-with-jsonnet/helm/02-configs-and-k8s-defaults': plugin api: grafana.com/v1alpha1, kind: ConfigResolver, name: config-resolver generated duplicate resource: {"group":"grafana.com","version":"v1alpha1","kind":"MimirConfig","name":"ingester","namespace":"default"}

[dimitarvdimitrov]

regarding migration guide: do you think we should help users estimate the time it will take to do the migration? This will also help them decide whether or not they want to do the migration or whether or not to do it without downtime. For example for the ingester migration without downtime:

Here is how to estimate the time it will take to complete the migration:

   24h (2 * querier.query_store_after)
 + 3h (blocks_storage.tsdb.block_ranges_period + blocks_storage.tsdb.head_compaction_idle_timeout)
 + 3h * (number_of_ingesters / 21) (wait for (blocks_storage.tsdb.block_ranges_period + blocks_storage.tsdb.head_compaction_idle_timeout) after each scale up of ingesters)
 = 27h + 3h * (number_of_ingesters / 21)

[dimitarvdimitrov]

also based on the discussion in https://github.com/grafana/mimir/pull/2953 - if we merge this PR and do a 4.0.0 release independently of mimir, then we should set this flag in this PR - ingester.ring.readiness-check-ring-health

not sure what your plans were, but decided to raise this so we are explicit about it

[krajorama]

also based on the discussion in #2953 - if we merge this PR and do a 4.0.0 release independently of mimir, then we should set this flag in this PR - ingester.ring.readiness-check-ring-health

not sure what your plans were, but decided to raise this so we are explicit about it

Plan is to use a recent enough Mimir so it is the default. Let's keep this comment open for reference.