loki icon indicating copy to clipboard operation
loki copied to clipboard

Add a process to ingester's series function to get series from storage

Open Di-Is opened this issue 2 years ago • 5 comments

What this PR does / why we need it: Unlike other functions (Query, Label...), ingester's series function does not have a function to retrieve data from storage. Because of this, the series included in the response of the series API is missing, so implement the function described above.

Which issue(s) this PR fixes: Fixes #9729

Special notes for your reviewer:

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [ ] Documentation added
  • [x] Tests updated
  • [x] CHANGELOG.md updated
    • [ ] If the change is worth mentioning in the release notes, add add-to-release-notes label
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md
  • [ ] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

Di-Is avatar Jun 19 '23 14:06 Di-Is

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 19 '23 14:06 CLAassistant

Thanks for the PR @Di-Is !

The general approach seems right to me. I need to further look at it in detail and check possible implications.

chaudum avatar Jun 23 '23 13:06 chaudum

We have the same issue here. The pr applied locally seems to solve the issue. Any plan to merge that soon?

CyrilPeponnet avatar Jan 25 '24 21:01 CyrilPeponnet

The code has been changed to match the latest main.

Di-Is avatar Jan 28 '24 08:01 Di-Is

The problem still exists in version 3.0.0.

Di-Is avatar May 16 '24 11:05 Di-Is