k6 icon indicating copy to clipboard operation
k6 copied to clipboard

Added information about built-in modules for Version command

Open amelkikh opened this issue 3 years ago • 3 comments
trafficstars

Hi! Please consider to review my PR. Additional information about built-in modules seems to be helpful when compiled tool shared with teammates.

Have a good day!

amelkikh avatar Sep 19 '22 17:09 amelkikh

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 19 '22 17:09 CLAassistant

Codecov Report

Merging #2686 (b9ea2eb) into master (7f823f0) will decrease coverage by 0.15%. The diff coverage is 75.52%.

@@            Coverage Diff             @@
##           master    #2686      +/-   ##
==========================================
- Coverage   75.59%   75.44%   -0.16%     
==========================================
  Files         202      207       +5     
  Lines       15992    16345     +353     
==========================================
+ Hits        12089    12331     +242     
- Misses       3151     3248      +97     
- Partials      752      766      +14     
Flag Coverage Δ
ubuntu 75.29% <75.52%> (-0.10%) :arrow_down:
windows 75.17% <75.52%> (-0.12%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/common/context.go 100.00% <ø> (ø)
api/server.go 71.42% <ø> (ø)
api/v1/client/client.go 0.00% <ø> (ø)
api/v1/client/metrics.go 0.00% <ø> (ø)
api/v1/client/status.go 0.00% <ø> (ø)
api/v1/errors.go 76.92% <ø> (ø)
api/v1/group.go 54.05% <ø> (ø)
api/v1/group_jsonapi.go 95.74% <ø> (ø)
api/v1/group_routes.go 60.86% <ø> (ø)
api/v1/metric.go 68.18% <ø> (ø)
... and 209 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 20 '22 07:09 codecov-commenter

Hi, @codebien!

Thanks for the detailed explanation. I share this approach with you. It will take me some time to figure out how to make a sign and dive into how your project works as I don't have much experience yet.

amelkikh avatar Sep 20 '22 10:09 amelkikh

Hi @amelkikh, did you hit some sort of issues implementing the suggestion? Can I help in some way? Thanks.

codebien avatar Oct 19 '22 12:10 codebien

Hi @amelkikh, did you hit some sort of issues implementing the suggestion? Can I help in some way? Thanks.

Hi @codebien! Unfortunately, I don't have enough time to continue developing this idea. I think that we can close this PR and return to implementation as there is real demand for this functionality

amelkikh avatar Oct 19 '22 12:10 amelkikh

Hi @amelkikh, thanks for your commitment and for letting us know. I hope we will see you as a contributor again in the future.

codebien avatar Oct 20 '22 08:10 codebien