k6-operator
k6-operator copied to clipboard
fix: put k6 crds in the appropriate folder specified by Helm
This PR aims to put CRDs folder in the appropriate folder specified by Helm which is charts/crds, so that we can skip installing CRDs whenever we want. Please refer to: https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds
I recon that an options installCRDs has been added here https://github.com/grafana/k6-operator/pull/342 but it would imo be better to follow the recommended structure and let helms skip-crds option handle this.
I'd like to see one of these two options
- have both options of
skip-crdsandinstallCRDs - only keep the standardized
skip-crdsand clean upinstallCRDs
Ah, I see, this would loose the option to template out CRDs - so keeping both installCRDs and using skip-crds may not be an option.
Relevant discussion on the topic: https://github.com/cert-manager/cert-manager/issues/6179
Perhaps https://github.com/grafana/k6-operator/issues/505 would actually be the better solution