k6-operator icon indicating copy to clipboard operation
k6-operator copied to clipboard

fix: put k6 crds in the appropriate folder specified by Helm

Open mariuskimmina opened this issue 11 months ago • 3 comments

This PR aims to put CRDs folder in the appropriate folder specified by Helm which is charts/crds, so that we can skip installing CRDs whenever we want. Please refer to: https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds

I recon that an options installCRDs has been added here https://github.com/grafana/k6-operator/pull/342 but it would imo be better to follow the recommended structure and let helms skip-crds option handle this.

I'd like to see one of these two options

  • have both options of skip-crds and installCRDs
  • only keep the standardized skip-crds and clean up installCRDs

mariuskimmina avatar Dec 12 '24 07:12 mariuskimmina

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 12 '24 07:12 CLAassistant

Ah, I see, this would loose the option to template out CRDs - so keeping both installCRDs and using skip-crds may not be an option.

Relevant discussion on the topic: https://github.com/cert-manager/cert-manager/issues/6179

mariuskimmina avatar Dec 12 '24 07:12 mariuskimmina

Perhaps https://github.com/grafana/k6-operator/issues/505 would actually be the better solution

mariuskimmina avatar Dec 12 '24 07:12 mariuskimmina